Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2a/3 Update hostmetrics disk scraper to use new perfcounters package #1836

Merged

Conversation

james-bebbington
Copy link
Member

@james-bebbington james-bebbington commented Sep 23, 2020

Link to tracking Issue: #973

Description:
 1. Add new perflib package
 2. Migrate host metrics scrapers to use new package
 3. Remove third_party PDH code

Depends on #1835

@james-bebbington james-bebbington changed the title Update hostmetrics disk scraper to use new perfcounters package 2/3 Update hostmetrics disk scraper to use new perfcounters package Sep 23, 2020
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #1836 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1836   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files         263      263           
  Lines       16105    16105           
=======================================
  Hits        14675    14675           
  Misses       1003     1003           
  Partials      427      427           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c32f36...a645c76. Read the comment docs.

@james-bebbington james-bebbington force-pushed the hostmetrics-disk-perfib branch 2 times, most recently from 8721ae3 to ec9875b Compare September 26, 2020 06:07
@james-bebbington james-bebbington changed the title 2/3 Update hostmetrics disk scraper to use new perfcounters package 2a/3 Update hostmetrics disk scraper to use new perfcounters package Sep 26, 2020
@james-bebbington james-bebbington force-pushed the hostmetrics-disk-perfib branch 2 times, most recently from 47247b3 to a645c76 Compare September 26, 2020 06:29
@bogdandrutu bogdandrutu merged commit 40544e7 into open-telemetry:master Sep 28, 2020
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#1836)

Bumps [boto3](https://github.com/boto/boto3) from 1.24.44 to 1.24.45.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.24.44...1.24.45)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants